[FFmpeg-devel] [PATCH] url_fskip: Warn if the url_fseek call failed
Fri Jul 16 19:49:09 CEST 2010
On Fri, Jul 16, 2010 at 08:26:46PM +0300, Martin Storsj? wrote:
> On Fri, 16 Jul 2010, Michael Niedermayer wrote:
> > On Fri, Jul 16, 2010 at 10:19:42AM -0400, Ronald S. Bultje wrote:
> > > Hi,
> > >
> > > On Fri, Jul 16, 2010 at 9:31 AM, Martin Storsj? <martin at martin.st> wrote:
> > > > $subj - url_fskip returns void at the moment, so if the wrapped url_fseek
> > > > call fails, at least tell the poor user that is debugging it what's going
> > > > wrong.
> > >
> > > Sometimes the seek intentionally is wrong, e.g. if the demuxer tests
> > > if the protocol can seek to a particular position.
> > >
> > > > Or would it be ok to change url_fskip to return int and pass the error
> > > > code through, and check for the errors in the individual demuxers?
> > >
> > > Probably... Michael can make a call here, he's maintainer.
> > passing the error code through seems more correct
> Ok, what about this one?
> I guess changing the return value from void to int doesn't break ABI on
> any platform we care about?
> // Martin
> avio.h | 3 ++-
> aviobuf.c | 5 +++--
> 2 files changed, 5 insertions(+), 3 deletions(-)
> c13efc44e09dfb429f8e58c1a0b87d7e84a474b7 0001-url_fskip-Return-an-error-code-if-the-url_fseek-fail.patch
> From 3afb4b2f8557600c4474149d3320300cb0e3266c Mon Sep 17 00:00:00 2001
> From: Martin Storsjo <martin at martin.st>
> Date: Fri, 16 Jul 2010 16:28:54 +0300
> Subject: [PATCH] url_fskip: Return an error code if the url_fseek failed
sould be ok
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel