[FFmpeg-devel] [PATCH 1/4] Doxygen sws_getColorspaceDetails(), and use saner names for the used tables.

Michael Niedermayer michaelni
Fri Jul 23 15:45:24 CEST 2010


On Fri, Jul 23, 2010 at 01:17:19AM +0200, Stefano Sabatini wrote:
> On date Monday 2010-05-24 02:57:57 +0200, Michael Niedermayer encoded:
> > On Sun, May 23, 2010 at 12:06:42PM +0200, Stefano Sabatini wrote:
> > > ---
> > >  swscale.h |   22 +++++++++++++++++-----
> > >  utils.c   |   18 +++++++++---------
> > >  2 files changed, 26 insertions(+), 14 deletions(-)
> > > 
> > > diff --git a/swscale.h b/swscale.h
> > > index f6e0ccf..888973c 100644
> > > --- a/swscale.h
> > > +++ b/swscale.h
> > > @@ -205,12 +205,24 @@ int sws_scale_ordered(struct SwsContext *context, const uint8_t* const src[],
> > >  #endif
> > >  
> > >  /**
> > > - * @param inv_table the yuv2rgb coefficients, normally ff_yuv2rgb_coeffs[x]
> > > - * @param fullRange if 1 then the luma range is 0..255 if 0 it is 16..235
> > > - * @return -1 if not supported
> > 
> > > + * Sets the colorspace conversion coefficients to use for RGB to YUV
> > > + * and RGB to YUV conversion, and the filtering values applied to the
> > > + * output image.
> > 
> > hmm
> > thats misses yuv->yuv, supported or not it definitly is supposed to be
> > handled too
> 
> Please give a definition of table and inv_table, what they are or what
> they are supposed to be.

from what i remember the idea was that one represents the input and one
the output and they would otherwise be identical
and how one is used you can see in the source, the other just needs to
be inverted (basic linear algebra) and applied for yuv->rgb or both
combined for yuv->yuv
and you can trivially check if you have gotten it correct by doing the
opposit convertion back and check if this matches withing rounding

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100723/9db4780b/attachment.pgp>



More information about the ffmpeg-devel mailing list