[FFmpeg-devel] [PATCH] Pictor/PC Paint PIC decoder

[Reimar Döffinger]

On Wed, Jun 02, 2010 at 09:26:26PM +1000, Peter Ross wrote:
> > I also fail to see the point of the nb_blocks variable and caring about it...
> > In particular since you might end up leaving part of the frame uninitialized
> > due to it.
> 
> True, but what if there is trailing data at the end of the file, not related
> to the image? Removing check would cause that data to be processed.

Are you sure? You should reach the end of the last plane exactly at the same
time as you have processed all blocks, if you can't assume that I think
you'd have to use reget_buffer and set the frame type to P instead of I.


> Also... any thoughts on CODEC_ID_PIC. It is rather generic, _PICTOR
> might be more appropriate.

Paint that bikeshed the way you like (though I agree PIC is a bad name).