[FFmpeg-devel] [PATCH] Pictor/PC Paint PIC decoder

Peter Ross pross
Thu Jun 3 13:57:10 CEST 2010

On Wed, Jun 02, 2010 at 07:17:07PM +0200, Reimar D?ffinger wrote:
> On Wed, Jun 02, 2010 at 09:26:26PM +1000, Peter Ross wrote:
> > > I also fail to see the point of the nb_blocks variable and caring about it...
> > > In particular since you might end up leaving part of the frame uninitialized
> > > due to it.
> > 
> > True, but what if there is trailing data at the end of the file, not related
> > to the image? Removing check would cause that data to be processed.
> Are you sure? You should reach the end of the last plane exactly at the same
> time as you have processed all blocks, if you can't assume that I think
> you'd have to use reget_buffer and set the frame type to P instead of I.

Fair point.

> > Also... any thoughts on CODEC_ID_PIC. It is rather generic, _PICTOR
> > might be more appropriate.
> Paint that bikeshed the way you like (though I agree PIC is a bad name).

Names should be as compact as possible without causing ambiguity.
Gonna take my own advice here.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pic-r4.diff
Type: text/x-diff
Size: 11816 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100603/37a08d92/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100603/37a08d92/attachment.pgp>

More information about the ffmpeg-devel mailing list