[FFmpeg-devel] [PATCH] av_log_missing_feature_once

Alexander Strange astrange
Wed Mar 24 20:51:47 CET 2010


On Mar 18, 2010, at 9:23 PM, Michael Niedermayer wrote:

> On Thu, Mar 18, 2010 at 05:45:41PM -0400, Alexander Strange wrote:
>> This prevents HE-AACv2 files from printing warnings about parametric stereo constantly.
>> 
>> It was suggested that every av_log_missing_feature call should only happen once, but that would mean adding a variable for each one (whether static or a context variable) and I think most of them are rare anyway.
>> 
> 
> i think we need a context variable, a function like in this patch that
> simplifies it is of course a good idea.
> but without such variable it is printed just once in the lifetime of an
> application. This is all fine for a application that plays one file once
> but something like xmms that may run for months really would misbehave quite
> a bit.

Here it is with a context variable.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-a-function-to-help-avoid-repeatedly-printing-mis.patch
Type: application/octet-stream
Size: 1817 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100324/c19047e4/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-aac-Use-av_log_missing_feature_once-for-parametric-s.patch
Type: application/octet-stream
Size: 1341 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100324/c19047e4/attachment-0001.obj>



More information about the ffmpeg-devel mailing list