[FFmpeg-devel] [PATCH] av_log_missing_feature_once
Wed Mar 24 20:56:27 CET 2010
On Wed, Mar 24, 2010 at 3:51 PM, Alexander Strange
<astrange at ithinksw.com> wrote:
> On Mar 18, 2010, at 9:23 PM, Michael Niedermayer wrote:
>> On Thu, Mar 18, 2010 at 05:45:41PM -0400, Alexander Strange wrote:
>>> This prevents HE-AACv2 files from printing warnings about parametric stereo constantly.
>>> It was suggested that every av_log_missing_feature call should only happen once, but that would mean adding a variable for each one (whether static or a context variable) and I think most of them are rare anyway.
>> i think we need a context variable, a function like in this patch that
>> simplifies it is of course a good idea.
>> but without such variable it is printed just once in the lifetime of an
>> application. This is all fine for a application that plays one file once
>> but something like xmms that may run for months really would misbehave quite
>> a bit.
> Here it is with a context variable.
I don't want to increase the amount of placeholder code that I'm just
going to have to remove when PS is ready in a few weeks. IIRC when a
similar idea was proposed for SBR and rejected with implementing SBR
being pushed as the correct solution.
More information about the ffmpeg-devel