[FFmpeg-devel] [PATCH] Fix Ogg data_offset computation.

Reimar Döffinger Reimar.Doeffinger
Mon Nov 22 22:17:41 CET 2010

On Mon, Nov 22, 2010 at 01:09:07PM -0800, Aaron Colwell wrote:
> Ok. Hopefully this is the last round. I've attached a new
> patch. It is essentially the code that Reimar gave me,
> except an additional check was added to only set the
> header field to 0 on streams that have the value set to > 0.

I'd appreciate it if the code had a few more comments.
Maybe the ones I gave weren't particularly good, but this
code has been changed over and over and each time it took
me ages to figure out what it is doing, IMO we desperately
need to increase the amount of comments/documentation in that
code (of course that doesn't mean randomly adding useless
comments like i++; /* increment i */ :-) ).

More information about the ffmpeg-devel mailing list