[FFmpeg-devel] [PATCH] Fix Ogg data_offset computation.

Aaron Colwell acolwell
Mon Nov 22 22:42:03 CET 2010

Ok. Here you go. I only removed the comments to match the
terseness of the rest of the file. A silly reason I know.

I agree that better documentation in there would make understanding
this code a whole lot easier. This is at least a start.

Thanks again for your help and I'm  sorry for the hit to your sanity. :)


On Mon, Nov 22, 2010 at 1:17 PM, Reimar D?ffinger
<Reimar.Doeffinger at gmx.de>wrote:

> On Mon, Nov 22, 2010 at 01:09:07PM -0800, Aaron Colwell wrote:
> > Ok. Hopefully this is the last round. I've attached a new
> > patch. It is essentially the code that Reimar gave me,
> > except an additional check was added to only set the
> > header field to 0 on streams that have the value set to > 0.
> I'd appreciate it if the code had a few more comments.
> Maybe the ones I gave weren't particularly good, but this
> code has been changed over and over and each time it took
> me ages to figure out what it is doing, IMO we desperately
> need to increase the amount of comments/documentation in that
> code (of course that doesn't mean randomly adding useless
> comments like i++; /* increment i */ :-) ).
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ogg_data_offset.patch
Type: text/x-patch
Size: 1447 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101122/e45cc065/attachment.bin>

More information about the ffmpeg-devel mailing list