[FFmpeg-devel] [PATCH 1/2] lavf: try reading id3v1 header for all formats
Mon Nov 29 19:43:21 CET 2010
On Mon, Nov 29, 2010 at 09:41:51AM +0100, Anton Khirnov wrote:
> similarly to id3v2 case, id3v1 headers can be found on anything, so it
> makes sense to check for their presence if the file is seekable and no
> other metadata was found.
Problem is "seeking possible" is not the same as (warning: extreme
exaggeration ahead) "seeking ok just to check for some metadata that
nobody cares about and almost certainly isn't there".
Which more or less is why I did not touch it, it seemed to me like
overall negative to do for all formats.
Michael's suggestion was to keep the code-deduplication with introducing
potentially extra issues by having a flag in the demuxer description
that says whether we should look for id3v1.
More information about the ffmpeg-devel