[FFmpeg-devel] [PATCH 1/2] lavf: try reading id3v1 header for all formats

Michael Karcher ffmpeg
Mon Nov 29 23:51:18 CET 2010


Am Montag, den 29.11.2010, 19:43 +0100 schrieb Reimar D?ffinger:
> On Mon, Nov 29, 2010 at 09:41:51AM +0100, Anton Khirnov wrote:
> > similarly to id3v2 case, id3v1 headers can be found on anything, so it
> > makes sense to check for their presence if the file is seekable and no
> > other metadata was found.
[...]
> Michael's suggestion was to keep the code-deduplication with introducing
> potentially extra issues by having a flag in the demuxer description
> that says whether we should look for id3v1.

The orginal claim was that id3v1 is attached to any format you can think
of, so annotating the format doesn't seem to make sense to me under
these circumstances. What would make sense to me would be introducing a
"seek is cheap" flag for easily seekable sources (like file://, unlike
http://).

Regards,
  Michael Karcher




More information about the ffmpeg-devel mailing list