[FFmpeg-devel] [PATCH] common ID3v2 support for all formats

Reimar Döffinger Reimar.Doeffinger
Fri Oct 1 20:21:07 CEST 2010

considering issue 2258 I think it is a valid conclusion that people
will prepend a ID3v2 header to anything that can't run aways fast enough
(and then give it a .mp3 extension...).
So I propose attached patch that moves that parsing to common code.
Note that is assume that due to buffering the ID3 parsing attempt
will not cause any issues even on non-seekable input.
Note that I have no idea WTF the mpc demuxer code is doing there,
my conclusion was that it should be safe to just throw it all away,
but I'm not 100% sure I don't miss some subtlety.
Mostly unrelated, but one issue with this whole ID3 handling is
that AFAICT it will use the file-specific metadata conversion
instead of using always the ID3 one.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: id3v2.diff
Type: text/x-diff
Size: 7527 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101001/6089cdeb/attachment.diff>

More information about the ffmpeg-devel mailing list