[FFmpeg-devel] [PATCH] common ID3v2 support for all formats

Michael Niedermayer michaelni
Fri Oct 1 23:27:36 CEST 2010

On Fri, Oct 01, 2010 at 08:21:07PM +0200, Reimar D?ffinger wrote:
> Hello,
> considering issue 2258 I think it is a valid conclusion that people
> will prepend a ID3v2 header to anything that can't run aways fast enough
> (and then give it a .mp3 extension...).
> So I propose attached patch that moves that parsing to common code.
> Note that is assume that due to buffering the ID3 parsing attempt
> will not cause any issues even on non-seekable input.
> Note that I have no idea WTF the mpc demuxer code is doing there,
> my conclusion was that it should be safe to just throw it all away,
> but I'm not 100% sure I don't miss some subtlety.
> Mostly unrelated, but one issue with this whole ID3 handling is
> that AFAICT it will use the file-specific metadata conversion
> instead of using always the ID3 one.

>  aacdec.c  |    5 -----
>  flacdec.c |   14 --------------
>  mp3.c     |    4 ----
>  mpc.c     |   34 ++++------------------------------
>  tta.c     |    8 --------
>  utils.c   |   16 ++++++++++++++--
>  6 files changed, 18 insertions(+), 63 deletions(-)
> 5cc1b70fabc75686a99488dd8c63693412e67935  id3v2.diff

iam ok with this if its tested and the mpc maintainer confirms the change is

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101001/f4025567/attachment.pgp>

More information about the ffmpeg-devel mailing list