[FFmpeg-devel] [patch] allow wordexp globs in image2 file sequence import

Carl Eugen Hoyos cehoyos
Sat Jan 1 16:11:23 CET 2011

Brian Olson <icic <at> bolson.org> writes:

> This is my first attempt at submitting to ffmpeg. I hope you like it. Feedback
> welcome. Hopefully I didn't break the conventions too much.

> -  if (av_get_frame_filename(filename, sizeof(filename),
> -                            s->path, s->img_number)<0 && s->img_number > 1)

> -        s->img_first = first_index;
> -        s->img_last = last_index;

Most people here think that you should not re-indent those lines within the same
patch that introduces functional changes to make reading the patch easier.

And consider fixing your line length.

Thank you for your contribution, Carl Eugen

More information about the ffmpeg-devel mailing list