[FFmpeg-devel] [RCF] lavfi aspect ratio setting path
Mon Jan 17 00:20:06 CET 2011
On Sun, Jan 16, 2011 at 04:56:42PM +0100, Stefano Sabatini wrote:
> On date Sunday 2010-12-12 12:34:10 -0800, Baptiste Coudurier encoded:
> > On 12/3/10 9:53 PM, Baptiste Coudurier wrote:
> > > On 12/2/10 6:28 PM, Michael Niedermayer wrote:
> > >> On Mon, Nov 29, 2010 at 03:26:40AM -0800, Baptiste Coudurier wrote:
> > >> [...]
> > >>> @@ -419,6 +430,10 @@
> > >>>
> > >>> codec->width = ist->output_video_filter->inputs->w;
> > >>> codec->height = ist->output_video_filter->inputs->h;
> > >>> + ost->st->sample_aspect_ratio = codec->sample_aspect_ratio =
> > >>
> > >>> + frame_aspect_ratio == 0 ? // overriden by the -aspect cli option
> > >>> + av_d2q(frame_aspect_ratio*codec->height/codec->width, 255) :
> > >>> + ist->output_video_filter->inputs->sample_aspect_ratio;
> > >>
> > >> that looks odd if frame_aspect_ratio == 0 then
> > >> av_d2q(frame_aspect_ratio*codec->height/codec->width, 255)
> > >> will be used
> > >> but thats av_d2q(0*codec->height/codec->width, 255)=0
> > >
> > > Yes you are right, it required more modifications to make it work.
> > > Updated patch.
> > >
> > Ping.
> Any news on this? This is a show-stopper for many users.
this patch does so many unrelated things iam just confused by it, i know
some of the changes are definitly wrong and introduce bugs then for some
i have no idea at all what they are supposed to do
point me to the issues on roundup and ill look into fixing them
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel