[FFmpeg-devel] [PATCH] movenc.c: fix metadata writing.

Ronald S. Bultje rsbultje
Fri Mar 4 03:56:27 CET 2011


On Thu, Mar 3, 2011 at 9:31 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> -static int mov_write_string_tag(AVIOContext *pb, const char *name, const char *value, int lang, int long_style){
> +static int mov_write_string_tag(AVIOContext *pb, uint32_t name, const char *value, int lang, int long_style){

Another possibility that also fixes this is to make "const char *name"
unsigned, so "const uint8_t *name" fixes the issue also. If you prefer
that for readability, fine, although then we're not replacing the
actual strings by fourcc literals, which was the point of this change
in the first place (i.e. you don't get any theoretical speed gain).

Then again, the speed gain is likely immeasurable so we might not care.


More information about the ffmpeg-devel mailing list