[FFmpeg-devel] [PATCH] movenc.c: fix metadata writing.

Baptiste Coudurier baptiste.coudurier
Fri Mar 4 04:23:33 CET 2011

On 03/03/2011 06:56 PM, Ronald S. Bultje wrote:
> Hi,
> On Thu, Mar 3, 2011 at 9:31 PM, Ronald S. Bultje<rsbultje at gmail.com>  wrote:
>> -static int mov_write_string_tag(AVIOContext *pb, const char *name, const char *value, int lang, int long_style){
>> +static int mov_write_string_tag(AVIOContext *pb, uint32_t name, const char *value, int lang, int long_style){
> Another possibility that also fixes this is to make "const char *name"
> unsigned, so "const uint8_t *name" fixes the issue also. If you prefer
> that for readability, fine, although then we're not replacing the
> actual strings by fourcc literals, which was the point of this change
> in the first place (i.e. you don't get any theoretical speed gain).

I think a tag is not a fourcc, so this change was not appropriate in the 
first place. There is no equivalent to put_tag anymore, put_str does 
something different.

That said this fix is better I think.


Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org

More information about the ffmpeg-devel mailing list