[FFmpeg-devel] [PATCH] Check return value of more avio_seek calls in rm/asf/avi
elupus at ecce.se
Mon Sep 12 00:19:55 CEST 2011
On Mon, 12 Sep 2011 00:19:04 +0200, Joakim Plate wrote:
> This reduces problems when underlying protocol is not
> seekable even if marked as such or if the file has been
> cut short.
> The move of avio_seek in avi_read_seek is to avoiding modifying
> state if the seek would fail.
> libavformat/asfdec.c | 10 +++++++---
> libavformat/avidec.c | 16 ++++++++++++----
> libavformat/rmdec.c | 4 +++-
> 3 files changed, 22 insertions(+), 8 deletions(-)
I'm not entirely sure a return value of -1 is good in these cases. But i'm
also not really sure what would be a good return value.
More information about the ffmpeg-devel