[FFmpeg-devel] [PATCH] Check return value of more avio_seek calls in rm/asf/avi
michaelni at gmx.at
Mon Sep 12 02:19:44 CEST 2011
On Mon, Sep 12, 2011 at 12:19:55AM +0200, Joakim Plate wrote:
> On Mon, 12 Sep 2011 00:19:04 +0200, Joakim Plate wrote:
> > This reduces problems when underlying protocol is not
> > seekable even if marked as such or if the file has been
> > cut short.
> > The move of avio_seek in avi_read_seek is to avoiding modifying
> > state if the seek would fail.
> > ---
> > libavformat/asfdec.c | 10 +++++++---
> > libavformat/avidec.c | 16 ++++++++++++----
> > libavformat/rmdec.c | 4 +++-
> > 3 files changed, 22 insertions(+), 8 deletions(-)
> I'm not entirely sure a return value of -1 is good in these cases. But i'm
> also not really sure what would be a good return value.
whoever has a good idea (i dont) is very welcome to change the return
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel