[FFmpeg-devel] [PATCH] lavfi: add ff_all_channel_layouts internal symbol

[Stefano Sabatini]

On date Monday 2011-09-12 22:44:54 +0200, Stefano Sabatini encoded:
> On date Monday 2011-09-12 03:19:17 +0200, Michael Niedermayer encoded:
> > On Sun, Sep 11, 2011 at 11:00:06AM +0200, Stefano Sabatini wrote:
> [...]
> > > a huge list of channel layouts, some may be not supported by
> > > libavfilter due to the unsupported number of channels
> > > 
> > > and such obscure definitions quickly lead to bugs/hacks.
> > > 
> > > That's why I prefer compile-time generation.
> > 
> > btw its 72 formats, thats 72 lines of code, the email above is 82 lines
> > it just doesnt seem enough for me to generate at compiletime (with
> > more code)
> > either way, if you want it at compile time iam perfectly fine with
> > that but i expect you to maintain it. (that is if changes elsewhere
> > break it for example)
> 
> I'm fine with the statically defined list if that's easier and simpler
> to maintain, what I want to avoid is special casing and extra
> (sometimes unexpected) complexity deriving from it.

Check patch.
-- 
FFmpeg = Fantastic Fundamental MultiPurpose Everlasting Gem
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-lavfi-add-avfilter_all_channel_layouts_int64-public-.patch
Type: text/x-diff
Size: 10463 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110913/f9b38bec/attachment.bin>