[FFmpeg-devel] [PATCH] lavfi: add ff_all_channel_layouts internal symbol
michaelni at gmx.at
Tue Sep 13 20:56:27 CEST 2011
On Tue, Sep 13, 2011 at 05:46:21PM +0200, Stefano Sabatini wrote:
> On date Monday 2011-09-12 22:44:54 +0200, Stefano Sabatini encoded:
> > On date Monday 2011-09-12 03:19:17 +0200, Michael Niedermayer encoded:
> > > On Sun, Sep 11, 2011 at 11:00:06AM +0200, Stefano Sabatini wrote:
> > [...]
> > > > a huge list of channel layouts, some may be not supported by
> > > > libavfilter due to the unsupported number of channels
> > > >
> > > > and such obscure definitions quickly lead to bugs/hacks.
> > > >
> > > > That's why I prefer compile-time generation.
> > >
> > > btw its 72 formats, thats 72 lines of code, the email above is 82 lines
> > > it just doesnt seem enough for me to generate at compiletime (with
> > > more code)
> > > either way, if you want it at compile time iam perfectly fine with
> > > that but i expect you to maintain it. (that is if changes elsewhere
> > > break it for example)
> > I'm fine with the statically defined list if that's easier and simpler
> > to maintain, what I want to avoid is special casing and extra
> > (sometimes unexpected) complexity deriving from it.
> Check patch.
fine with me
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel