[FFmpeg-devel] [PATCH] mov: do not print string len in handler_name.

Michael Niedermayer michaelni at gmx.at
Thu Apr 5 17:13:14 CEST 2012

On Thu, Apr 05, 2012 at 03:28:44PM +0200, Clément Bœsch wrote:
> From: Clément Bœsch <clement.boesch at smartjog.com>
> The handler name is stored as a pascal string in the QT specs (first
> byte is the length of the string), thus leading to an invalid metadata
> string export.
> Also add a second length check based on the first character to avoid
> overwriting an already specified handler_name (it happens with Youtube
> videos for instance, the handler_name get masked), or specifying an
> empty string metadata.

if these checks work, surely LGTM

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120405/4260d1f6/attachment.asc>

More information about the ffmpeg-devel mailing list