[FFmpeg-devel] [PATCH] mov: do not print string len in handler_name.

Clément Bœsch ubitux at gmail.com
Thu Apr 5 17:33:37 CEST 2012


On Thu, Apr 05, 2012 at 05:13:14PM +0200, Michael Niedermayer wrote:
> On Thu, Apr 05, 2012 at 03:28:44PM +0200, Clément Bœsch wrote:
> > From: Clément Bœsch <clement.boesch at smartjog.com>
> > 
> > The handler name is stored as a pascal string in the QT specs (first
> > byte is the length of the string), thus leading to an invalid metadata
> > string export.
> > 
> > Also add a second length check based on the first character to avoid
> > overwriting an already specified handler_name (it happens with Youtube
> > videos for instance, the handler_name get masked), or specifying an
> > empty string metadata.
> 
> if these checks work, surely LGTM
> 

Thanks, pushed.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120405/424c5851/attachment.asc>


More information about the ffmpeg-devel mailing list