[FFmpeg-devel] [PATCH] matroskadec: use av_grow_packet in merge_packets.

Nicolas George nicolas.george at normalesup.org
Mon Apr 16 22:04:25 CEST 2012

L'octidi 28 germinal, an CCXX, Reimar Döffinger a écrit :
> I think that should be "ret < 0".

Fixed locally, although it is currently equivalent.

> And I don't know if that might not leak memory on error (not sure what
> exactly that function does on error).

It leaves the packet unchanged. I believe it would be up to the surrounding
code to free the packets in case of failure.

(Granted, right now, the surrounding code does not even check for failure.
But that is an unrelated issue.)

Thanks for the review.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120416/14e22a6a/attachment.asc>

More information about the ffmpeg-devel mailing list