[FFmpeg-devel] [PATCH] matroskadec: use av_grow_packet in merge_packets.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Mon Apr 16 22:16:29 CEST 2012

On Mon, Apr 16, 2012 at 10:04:25PM +0200, Nicolas George wrote:
> L'octidi 28 germinal, an CCXX, Reimar Döffinger a écrit :
> > I think that should be "ret < 0".
> Fixed locally, although it is currently equivalent.
> > And I don't know if that might not leak memory on error (not sure what
> > exactly that function does on error).
> It leaves the packet unchanged. I believe it would be up to the surrounding
> code to free the packets in case of failure.

Since that matches the current behaviour I'd say that is ok.
>From my side the patch seems good.

More information about the ffmpeg-devel mailing list