[FFmpeg-devel] [PATCH] mss1: improve check if decoded pivot is invalid
Paul B Mahol
onemda at gmail.com
Sun Jul 15 04:16:19 CEST 2012
On 7/15/12, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sun, Jul 15, 2012 at 12:50:50AM +0000, Paul B Mahol wrote:
>> On 7/15/12, Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
>> > On 14/07/2012 8:39 PM, Paul B Mahol wrote:
>> >>> Can you add an actual explanation of what you fixed
>> >>> > into the commit message?
>> >> You mean bug report or explanation what that C code does?
>> > In what way does it 'improve' it? What does it fix? You
>> > don't even have a bug tracker ID. This commit is completely
>> > missing any useful information at all.
>> Get over it. I had enough of such hypocrite reviews with Libav.
> I think derek just wants a more elaborate commit message that explains
> with more detail what this fixes and why and how.
> Maybe something like:
> the pivot has to lie between 0 and base thus a check of ==base is
> insufficient. Thus replace it by a proper check
> IMHO adding that extra line is not a bad idea, though its no major
> thing to me if that line is there or not. Its a major thing to others
> it seems ...
Pushed with that explanation.
More information about the ffmpeg-devel