[FFmpeg-devel] [PATCH] lavd/lavfi: do not set the channel layout list.
stefasab at gmail.com
Thu Jun 21 12:04:19 CEST 2012
On date Thursday 2012-06-21 09:57:48 +0200, Nicolas George encoded:
> The list was set to avfilter_all_channel_layouts,
> which is really all common channel layouts.
> Not setting it leaves an empty list,
> which now means really all.
> Should fix trac ticket #1474.
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> libavdevice/lavfi.c | 2 --
> 1 file changed, 2 deletions(-)
> diff --git a/libavdevice/lavfi.c b/libavdevice/lavfi.c
> index bdc5f58..5387a86 100644
> --- a/libavdevice/lavfi.c
> +++ b/libavdevice/lavfi.c
> @@ -211,10 +211,8 @@ av_cold static int lavfi_read_header(AVFormatContext *avctx)
> AV_SAMPLE_FMT_DBL, -1 };
> - const int64_t *chlayouts = avfilter_all_channel_layouts;
> AVABufferSinkParams *abuffersink_params = av_abuffersink_params_alloc();
> abuffersink_params->sample_fmts = sample_fmts;
> - abuffersink_params->channel_layouts = chlayouts;
> ret = avfilter_graph_create_filter(&sink, abuffersink,
> inout->name, NULL,
Patch should be fine, but I can't see how this is related to #1474,
since the reporter is not even using the lavfi device.
[On a different ground, I don't like the NONE=ALL assumption because
it can lead to subtle bugs, an empty list is semantically different
from a "complete" list, in case I use some automated way to create a
list, with this assumption I need to check for the special case, which
wouldn't be required with a proper representation.]
FFmpeg = Fundamentalist & Fundamentalist Martial Pure Elastic Gospel
More information about the ffmpeg-devel