[FFmpeg-devel] [PATCH] lavd/lavfi: do not set the channel layout list.
nicolas.george at normalesup.org
Thu Jun 21 19:52:44 CEST 2012
Le quartidi 4 messidor, an CCXX, Stefano Sabatini a écrit :
> Patch should be fine, but I can't see how this is related to #1474,
> since the reporter is not even using the lavfi device.
That is true. The story is that I used -f lavfi to get a similar problem (a
file with the "FL" channel layout), fixed the bug, and forgot to check
further. Now I can not reproduce ticket #1474.
Pushed without the reference to the ticket.
> [On a different ground, I don't like the NONE=ALL assumption because
> it can lead to subtle bugs, an empty list is semantically different
> from a "complete" list, in case I use some automated way to create a
> list, with this assumption I need to check for the special case, which
> wouldn't be required with a proper representation.]
Unless I am mistaken, an empty list is never acceptable, so you need to
check for the special case at one place or another anyway.
I find this convention rather well designed, in fact.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel