[FFmpeg-devel] [PATCH 1/2] Fix DPX decoder Rewrite the DPX decoder to work with provided sample DPXs

mashiat.sarker at gmail.com mashiat.sarker at gmail.com
Thu Oct 4 22:34:04 CEST 2012

On 10/04/2012 01:48 PM, Georg Lippitsch wrote:
> ---
>   libavcodec/dpx.c |  157 +++++++++++++++++++++++++++++-------------------------
>   1 files changed, 84 insertions(+), 73 deletions(-)

Your patch looks like a series of fixes squashed together in one patch. 
It does not explain what was our decoder doing wrong and how you have 
fixed that. Just saying that your patch fixes a bunch of sample is not 

I propose you split your patch into a patchset. From a quick look at 
your patch, it seemed completely doable to me. Feel free to correct me 
if I am wrong.

Also, your patch is not properly formatted. Please read the guideline 
for code formatting.


More information about the ffmpeg-devel mailing list