[FFmpeg-devel] [PATCH 1/2] Fix DPX decoder Rewrite the DPX decoder to work with provided sample DPXs

Georg Lippitsch georg.lippitsch at gmx.at
Thu Oct 4 23:01:41 CEST 2012

Am 04.10.2012, 22:34 Uhr, schrieb mashiat.sarker at gmail.com  
<mashiat.sarker at gmail.com>:

> On 10/04/2012 01:48 PM, Georg Lippitsch wrote:
>> ---
>>   libavcodec/dpx.c |  157  
>> +++++++++++++++++++++++++++++-------------------------
>>   1 files changed, 84 insertions(+), 73 deletions(-)
> Your patch looks like a series of fixes squashed together in one patch.  
> It does not explain what was our decoder doing wrong and how you have  
> fixed that. Just saying that your patch fixes a bunch of sample is not  
> enough.

Please follow discussion to message  
<1346155638-23632-1-git-send-email-georg.lippitsch at gmx.at>
(Subject: [PATCH] dpx: fix some stupid typos)

Holger provided some DPX samples and it turned out that many of them  
didn't open properly.

> I propose you split your patch into a patchset. From a quick look at  
> your patch, it seemed completely doable to me. Feel free to correct me  
> if I am wrong.

There seem to be some disagreement on patchsets on this list. When I  
recently submitted some patch sets, people suggested to merge into one  
patch. Could you elaborate on why it should be a patch set this time?

> Also, your patch is not properly formatted. Please read the guideline  
> for code formatting.

I checked with patcheck, and it seemed fine. Again, could you give some  
hints what is wrong formatted?
If you only point to some flawed indenting, I'll fix them after the first  
more technical review of the patch.



More information about the ffmpeg-devel mailing list