[FFmpeg-devel] patch for bug https://ffmpeg.org/trac/ffmpeg/ticket/1718#comment:7
michaelni at gmx.at
Fri Sep 14 05:56:23 CEST 2012
On Sun, Sep 09, 2012 at 07:14:37PM -0700, Sheng Chen wrote:
> For this issue, I've added analysis in the ticket.
> The root cause for this issue is the mpeg audio header in this file is changed.
> The first mpeg audio header is 0xFFFFE275, the others are 0xFFFFE205.
> When mpegaudio_parse() first check the header and set it to pc->state,
> Then when parse the second packet, it would first get the header 0xFFE275FF,
> It is a valid mpeg audio header but invalid for this file.
> So, it gets the wrong size and wrong info.
> I attached the patch and the first four packets,
> The issue file I attached in the ticket seems damaged.
> If you want to get the original file, I'll send to you in another way.
fixed locally, will be in git in a moment
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel