[FFmpeg-devel] [PATCH 2/2] compat/vsnprintf: return number of bytes required on truncation.
Reimar.Doeffinger at gmx.de
Sat Sep 15 16:45:58 CEST 2012
On Sat, Sep 15, 2012 at 07:13:14AM -0700, Ronald S. Bultje wrote:
> On Fri, Sep 14, 2012 at 7:10 PM, jamal <jamrial at gmail.com> wrote:
> > On 14/09/12 8:58 PM, compn wrote:
> >> On Fri, 14 Sep 2012 15:08:20 -0400, Derek Buitenhuis wrote:
> >>> From: "Ronald S. Bultje" <rsbultje at gmail.com>
> >>> This conforms to C99, but requires Windows >= XP.
> >> no more win2k or win98 support... :(
> >> -compn
> > This is for MVSC, right? It's not like Microsoft supports those platforms anymore with their compiler anyway.
> +1 on this. MSVC support has only been tested on MSVS 2010, and that
> requires XP SP2:
First, exactly that was the question: Does this only affect building
> Also, how much do you want to be part of a botnet to be running Windows 98?
Obviously nonsense arguments like this are really counter-productive
1) even today it is still quite possible to just not connect a computer to the
internet, and FFmpeg still works fine without one
2) are there even any botnet programs around that will still run on Windows 98?
Generally I think we can handle it the usual way for fringe platforms:
If someone is willing to maintain it and it does not make the code too
messy that is welcome.
Though I have to say that the *snprintf return value is the typical kind
of thing that I think is quite likely to have bugs because it is rather
complex to implement and thus I'd in principle prefer to not rely on it
if reasonably avoidable...
More information about the ffmpeg-devel