[FFmpeg-devel] [PATCH 2/2] compat/vsnprintf: return number of bytes required on truncation.

Ronald S. Bultje rsbultje at gmail.com
Sat Sep 15 17:37:51 CEST 2012


Hi,

On Sat, Sep 15, 2012 at 7:45 AM, Reimar Döffinger
<Reimar.Doeffinger at gmx.de> wrote:
> On Sat, Sep 15, 2012 at 07:13:14AM -0700, Ronald S. Bultje wrote:
>> On Fri, Sep 14, 2012 at 7:10 PM, jamal <jamrial at gmail.com> wrote:
>> > On 14/09/12 8:58 PM, compn wrote:
>> >> On Fri, 14 Sep 2012 15:08:20 -0400, Derek Buitenhuis wrote:
>> >>> From: "Ronald S. Bultje" <rsbultje at gmail.com>
>> >>>
>> >>> This conforms to C99, but requires Windows >= XP.
>> >>
>> >> no more win2k or win98 support... :(
>> >>
>> >> -compn
>> >>
>> > This is for MVSC, right? It's not like Microsoft supports those platforms anymore with their compiler anyway.
>>
>> +1 on this. MSVC support has only been tested on MSVS 2010, and that
>> requires XP SP2:
>
> First, exactly that was the question: Does this only affect building
> with MSVC?

Yes.

>> https://connect.microsoft.com/VisualStudio/feedback/details/526821/executables-built-with-visual-c-2010-do-not-run-on-windows-xp-prior-to-sp2
>>
>> Also, how much do you want to be part of a botnet to be running Windows 98?
>
> Obviously nonsense arguments
[..]
> Though I have to say that the *snprintf return value is the typical kind
> of thing that I think is quite likely to have bugs because it is rather
> complex to implement and thus I'd in principle prefer to not rely on it
> if reasonably avoidable...

Good luck getting that to work. Send a patch. :-).

Ronald


More information about the ffmpeg-devel mailing list