[FFmpeg-devel] [PATCH] lavf/mov: atom box parsing return eof cause play fail

Michael Niedermayer michael at niedermayer.cc
Thu Dec 7 22:42:28 EET 2017

On Thu, Dec 07, 2017 at 05:47:46PM +0800, tiejun.peng wrote:
> fix eof lead to play fail.
> Signed-off-by: tiejun.peng <tiejun.peng at foxmail.com>
> ---
>  libavformat/mov.c | 47 ++++++++++++++++++++++++++++++++++++-----------
>  1 file changed, 36 insertions(+), 11 deletions(-)

please split the addition of warning messages from the change to
EOF behavior

did you check that every EOF return case is safe to continue as if
no error occured ?
That change has quite wide effects possibly unless i misunderstand.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171207/0f6b686b/attachment.sig>

More information about the ffmpeg-devel mailing list