[FFmpeg-devel] [PATCH] lavf/mov: atom box parsing return eofcause play fail

Tiejun.Peng tiejun.peng at foxmail.com
Fri Dec 8 18:06:47 EET 2017

yes,  i have checked this case and i have done a lot of tests  with .mp4 file and fate

------------------ Original ------------------
From:  "Michael Niedermayer";<michael at niedermayer.cc>;
Send time: Friday, Dec 8, 2017 4:42 AM
To: "FFmpeg development discussions and patches"<ffmpeg-devel at ffmpeg.org>; 
Subject:  Re: [FFmpeg-devel] [PATCH] lavf/mov: atom box parsing return eofcause play fail

On Thu, Dec 07, 2017 at 05:47:46PM +0800, tiejun.peng wrote: > fix eof lead to play fail. >  > Signed-off-by: tiejun.peng <tiejun.peng at foxmail.com> > --- >  libavformat/mov.c | 47 ++++++++++++++++++++++++++++++++++++----------- >  1 file changed, 36 insertions(+), 11 deletions(-)  please split the addition of warning messages from the change to EOF behavior did you check that every EOF return case is safe to continue as if no error occured ? That change has quite wide effects possibly unless i misunderstand. [...] --  Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

More information about the ffmpeg-devel mailing list