[Ffmpeg-cvslog] r5918 - in trunk/libavcodec/ppc: dsputil_altivec.c dsputil_altivec.h dsputil_ppc.c

[Michael Niedermayer]

Hi

On Fri, Aug 04, 2006 at 03:23:51AM +0200, Luca Barbato wrote:
[...]
> > 
> > [...]
> >> @@ -256,62 +259,32 @@
> >>  {
> >>      // Common optimizations whether Altivec is available or not
> >>  
> >> -  switch (check_dcbzl_effect()) {
> >> -  case 32:
> >> -    c->clear_blocks = clear_blocks_dcbz32_ppc;
> >> -    break;
> >> -  case 128:
> >> -    c->clear_blocks = clear_blocks_dcbz128_ppc;
> >> -    break;
> >> -  default:
> >> -    break;
> >> -  }
> >> +    switch (check_dcbzl_effect()) {
> >> +        case 32:
> >> +            c->clear_blocks = clear_blocks_dcbz32_ppc;
> >> +            break;
> >> +        case 128:
> >> +            c->clear_blocks = clear_blocks_dcbz128_ppc;
> >> +            break;
> >> +        default:
> >> +            break;
> >> +    }
> >>  
> >>  #ifdef HAVE_ALTIVEC
> >> -  dsputil_h264_init_ppc(c, avctx);
> >> +    dsputil_h264_init_ppc(c, avctx);
> > 
> > [...]
> >> -      if (avctx->lowres==0)
> >> -      {
> >> +        if (avctx->lowres==0)
> >> +        {
> >>          if ((avctx->idct_algo == FF_IDCT_AUTO) ||
> >>                  (avctx->idct_algo == FF_IDCT_ALTIVEC))
> >>          {
> >>              c->idct_put = idct_put_altivec;
> >>              c->idct_add = idct_add_altivec;
> >> -#ifndef ALTIVEC_USE_REFERENCE_C_CODE
> >> +        #ifndef ALTIVEC_USE_REFERENCE_C_CODE
> >>              c->idct_permutation_type = FF_TRANSPOSE_IDCT_PERM;
> >> -#else /* ALTIVEC_USE_REFERENCE_C_CODE */
> >> +        #else /* ALTIVEC_USE_REFERENCE_C_CODE */
> >>              c->idct_permutation_type = FF_NO_IDCT_PERM;
> >> -#endif /* ALTIVEC_USE_REFERENCE_C_CODE */
> >> +        #endif /* ALTIVEC_USE_REFERENCE_C_CODE */
> >> +        }
> >>          }
> >> -      }
> > 
> > that too should be in a seperate commit
> 
> I could rename the commit to "Cosmetics all around the file" so it will
> be quite descriptive of it as whole ^^;

yes. something like that would be nice ...


> 
> (the change from variables to cast is spurious, the 2->4 spaces and the
> reorder was on purpose since I consider both cosmetic)
> 
> > 
> > sadly svn doesnt provide a way to reverse this? :(((((((
> 
> I can revert the files to the previous status with up -r
> previous_revision and then ci again.

no, rather implement real reversal support like cvs admin and send a
patch to the svn developers ;)


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is