[Ffmpeg-cvslog] r8189 - trunk/libavformat/swf.c

[Baptiste Coudurier]

Hi

Benjamin Larsson wrote:
> Alex Beregszaszi skrev:
>> Hi,
>>
>>  
>>> +static const AVCodecTag swf_audio_codec_tags[] = {
>>> +    {CODEC_ID_PCM_S16LE,  0x00},
>>> +    {CODEC_ID_ADPCM_SWF,  0x01},
>>> +    {CODEC_ID_MP3,        0x02},
>>> +    {CODEC_ID_PCM_S16LE,  0x03},
>>> +  //{CODEC_ID_NELLYMOSER, 0x06},
>>> +    {0, 0},
>>> +};
>>>     
>>
>> Why not use this table in flv* too?
>>
>> -- 
>> Alex Beregszaszi
>>   
> 
> This table is a duplicate of a table in flvenc.c, why not move it to
> flv.h and include flv.h in swf.c ?
> 
> static const AVCodecTag flv_audio_codec_ids[] = {
>    {CODEC_ID_MP3,       FLV_CODECID_MP3    >> FLV_AUDIO_CODECID_OFFSET},
>    {CODEC_ID_PCM_S8,    FLV_CODECID_PCM_BE >> FLV_AUDIO_CODECID_OFFSET},
>    {CODEC_ID_PCM_S16BE, FLV_CODECID_PCM_BE >> FLV_AUDIO_CODECID_OFFSET},
>    {CODEC_ID_PCM_S16LE, FLV_CODECID_PCM_LE >> FLV_AUDIO_CODECID_OFFSET},
>    {CODEC_ID_ADPCM_SWF, FLV_CODECID_ADPCM  >> FLV_AUDIO_CODECID_OFFSET},
>    {CODEC_ID_NONE,      0}
> };
> 

feel free to do so but remove that >> ugliness and useless FLV_CODECID enum.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312