[Ffmpeg-cvslog] r8189 - trunk/libavformat/swf.c

[Michael Niedermayer]

Hi

On Fri, Mar 02, 2007 at 01:16:10PM +0100, Benjamin Larsson wrote:
> Alex Beregszaszi skrev:
> >Hi,
> >
> >  
> >>+static const AVCodecTag swf_audio_codec_tags[] = {
> >>+    {CODEC_ID_PCM_S16LE,  0x00},
> >>+    {CODEC_ID_ADPCM_SWF,  0x01},
> >>+    {CODEC_ID_MP3,        0x02},
> >>+    {CODEC_ID_PCM_S16LE,  0x03},
> >>+  //{CODEC_ID_NELLYMOSER, 0x06},
> >>+    {0, 0},
> >>+};
> >>    
> >
> >Why not use this table in flv* too?
> >
> >--
> >Alex Beregszaszi
> >  
> 
> This table is a duplicate of a table in flvenc.c, why not move it to 
> flv.h and include flv.h in swf.c ?

the table belongs in a common object not header which would duplicate it
placing it in a new flvswf_common.c or flv.c would be an option ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070302/0fcbc71c/attachment.pgp>