[FFmpeg-cvslog] r10764 - trunk/libavcodec/imgconvert_template.h

[Reimar Döffinger]

Hello,
On Wed, Oct 17, 2007 at 11:34:49AM +0200, diego wrote:
> Author: diego
> Date: Wed Oct 17 11:34:48 2007
> New Revision: 10764
> 
> Log:
> Add a comment that explains why this header lacks multiple inclusion guards.
> 
> 
> Modified:
>    trunk/libavcodec/imgconvert_template.h
> 
> Modified: trunk/libavcodec/imgconvert_template.h
> ==============================================================================
> --- trunk/libavcodec/imgconvert_template.h	(original)
> +++ trunk/libavcodec/imgconvert_template.h	Wed Oct 17 11:34:48 2007
> @@ -19,6 +19,9 @@
>   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>   */
>  
> +/* This header has no multiple inclusion guards as it gets
> + * included multiple times. */
> +

That sounds confusing. I'd suggest something more like (improvements
welcome):
"This header intentionally has no inclusion guards."
"It generates different code depending on defines and thus must be fully
 included each time"

Greetings,
Reimar D?ffinger