[FFmpeg-cvslog] r10764 - trunk/libavcodec/imgconvert_template.h
Diego Biurrun
diego
Wed Oct 17 20:23:49 CEST 2007
On Wed, Oct 17, 2007 at 11:52:19AM +0200, Reimar D?ffinger wrote:
> On Wed, Oct 17, 2007 at 11:34:49AM +0200, diego wrote:
> >
> > Log:
> > Add a comment that explains why this header lacks multiple inclusion guards.
> >
> > --- trunk/libavcodec/imgconvert_template.h (original)
> > +++ trunk/libavcodec/imgconvert_template.h Wed Oct 17 11:34:48 2007
> > @@ -19,6 +19,9 @@
> >
> > +/* This header has no multiple inclusion guards as it gets
> > + * included multiple times. */
>
> That sounds confusing. I'd suggest something more like (improvements
> welcome):
> "This header intentionally has no inclusion guards."
> "It generates different code depending on defines and thus must be fully
> included each time"
I just committed
/* This header intentionally has no multiple inclusion guards. It is meant to
* be included multiple times and generates different code depending on the
* value of certain #defines. */
I hope that does the trick.
Diego
More information about the ffmpeg-cvslog
mailing list