[FFmpeg-cvslog] r19728 - in trunk/libavcodec: dsputil.c dsputil.h twinvq.c x86/dsputil_mmx.c

[Vitor Sessak]

Diego Biurrun wrote:
> On Thu, Aug 27, 2009 at 04:49:37PM +0200, vitor wrote:
>> --- trunk/libavcodec/dsputil.c	Thu Aug 27 15:41:29 2009	(r19727)
>> +++ trunk/libavcodec/dsputil.c	Thu Aug 27 16:49:36 2009	(r19728)
>> @@ -4093,6 +4093,51 @@ static void int32_to_float_fmul_scalar_c
>>  
>> +static inline uint32_t clipf_c_one(uint32_t a, uint32_t mini,
>> +                   uint32_t maxi, uint32_t maxisign)
> 
> indentation
> 
>> +    if(a > mini) return mini;
>> +    else if((a^(1<<31)) > maxisign) return maxi;
>> +    else return a;
> 
> if (
> 
> .. and this is ugly all on the same line.
> 
>> +static void vector_clipf_c_opposite_sign(float *dst, float *src, float *min, float *max, int len){
> 
> long line, not K&R and inconsistent with what you did 5 lines above..
> 
>> +    for(i=0; i<len; i+=8) {
> 
> for (i = 0; i < len; i += 8) {
> 
>> +static void vector_clipf_c(float *dst, float *src, float min, float max, int len){
> 
> ditto
> 
>> +    if(min < 0 && max > 0) {
> 
> ditto
> 
>> +        for(i=0; i < len; i+=8) {
> 
> ditto

The whole file is weirdly indented. I think it is a rather pointless and 
tiring exercise to try to compromise consistency with the rest of the 
file and K&R. Do you volunteer to reindent it?

-Vitor