[FFmpeg-cvslog] r19728 - in trunk/libavcodec: dsputil.c dsputil.h twinvq.c x86/dsputil_mmx.c

Diego Biurrun diego
Thu Aug 27 17:29:16 CEST 2009


On Thu, Aug 27, 2009 at 05:26:25PM +0200, Vitor Sessak wrote:
> Diego Biurrun wrote:
> >On Thu, Aug 27, 2009 at 04:49:37PM +0200, vitor wrote:
> >>--- trunk/libavcodec/dsputil.c	Thu Aug 27 15:41:29 2009 (r19727)
> >>+++ trunk/libavcodec/dsputil.c	Thu Aug 27 16:49:36 2009 (r19728)
> >>@@ -4093,6 +4093,51 @@ static void int32_to_float_fmul_scalar_c
> >> 
> >>+static inline uint32_t clipf_c_one(uint32_t a, uint32_t mini,
> >>+                   uint32_t maxi, uint32_t maxisign)
> >
> >indentation
> >[...]
> 
> The whole file is weirdly indented.

Yes, so?

> I think it is a rather pointless and tiring exercise to try to
> compromise consistency with the rest of the file and K&R.

I do not think this is a good excuse to commit new functions that not
even consistently formatted within themselves.

> Do you volunteer to reindent it?

Maybe.

Diego



More information about the ffmpeg-cvslog mailing list