[FFmpeg-cvslog] r17317 - trunk/libavcodec/mpegvideo_xvmc.c

[Michael Niedermayer]

On Sun, Feb 15, 2009 at 11:06:24AM +0100, iive wrote:
> Author: iive
> Date: Sun Feb 15 11:06:23 2009
> New Revision: 17317
> 
> Log:
> Check all critical xvmc struct fields in ff_xvmc_field_start()
> and log error if they are not correct. All other functions
> are supposedly called after that one, so use assert() for them.

and 1 point for you too for the assert/if cleanup
[...]
>      if (render->filled_mv_blocks_num) {
>          av_log(avctx, AV_LOG_ERROR,
> -               "Rendering surface contains %i unprocessed blocks\n",
> +               "Rendering surface contains %i unprocessed blocks.\n",
>                 render->filled_mv_blocks_num);
>          return -1;

i think ive warned you at least once already to split things sanely and not
commit random trash and there also was the leet reindent ...
so
-5, next time its 10 for you & diego if you mix cosmetics & functional changes

diego: 15
ivan: 10.5

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090215/f879a9c6/attachment.pgp>