[FFmpeg-cvslog] r17317 - trunk/libavcodec/mpegvideo_xvmc.c

[Diego Biurrun]

On Sun, Feb 15, 2009 at 06:59:48PM +0100, Michael Niedermayer wrote:
> On Sun, Feb 15, 2009 at 11:06:24AM +0100, iive wrote:
> > 
> > Log:
> > Check all critical xvmc struct fields in ff_xvmc_field_start()
> > and log error if they are not correct. All other functions
> > are supposedly called after that one, so use assert() for them.
> 
> and 1 point for you too for the assert/if cleanup
> [...]
> >      if (render->filled_mv_blocks_num) {
> >          av_log(avctx, AV_LOG_ERROR,
> > -               "Rendering surface contains %i unprocessed blocks\n",
> > +               "Rendering surface contains %i unprocessed blocks.\n",
> >                 render->filled_mv_blocks_num);
> >          return -1;
> 
> i think ive warned you at least once already to split things sanely and not
> commit random trash and there also was the leet reindent ...
> so
> -5, next time its 10 for you & diego if you mix cosmetics & functional changes

No penalty for committing a duplicated hunk? ;-p

Diego