[FFmpeg-devel] [PATCH] add a close function to bitstream filter

[Aurelien Jacobs]

On Mon, 03 Sep 2007 14:16:06 +0200
Benoit Fouet <benoit.fouet at purplelabs.com> wrote:

> Hi,
> 
> here is a patch to $subj
> 
> [...]
> 
> Index: libavcodec/avcodec.h
> ===================================================================
> --- libavcodec/avcodec.h	(revision 10287)
> +++ libavcodec/avcodec.h	(working copy)
> @@ -33,8 +33,8 @@
>  #define AV_STRINGIFY(s)         AV_TOSTRING(s)
>  #define AV_TOSTRING(s) #s
>  
> -#define LIBAVCODEC_VERSION_INT  ((51<<16)+(42<<8)+0)
> -#define LIBAVCODEC_VERSION      51.42.0
> +#define LIBAVCODEC_VERSION_INT  ((51<<16)+(42<<8)+1)
> +#define LIBAVCODEC_VERSION      51.42.1
>  #define LIBAVCODEC_BUILD        LIBAVCODEC_VERSION_INT

I think adding such a feature would require incresing minor, not micro...

> Index: libavcodec/remove_extradata_bsf.c
> ===================================================================
> --- libavcodec/remove_extradata_bsf.c	(revision 10287)
> +++ libavcodec/remove_extradata_bsf.c	(working copy)
> @@ -52,4 +52,5 @@
>      "remove_extra",
>      0,
>      remove_extradata,
> +    NULL,
>  };

All those NULLs added to the end of existing bsfs are useless.

Except those comments, patch looks fine.

Aurel