[FFmpeg-devel] [PATCH] DNxHD/VC-3 encoder

[Baptiste Coudurier]

Hi

Diego Biurrun wrote:
> On Tue, Sep 04, 2007 at 07:39:46PM +0200, Baptiste Coudurier wrote:
>> Here is the encoder.
>>
>> --- libavcodec/dnxhdenc.c	(revision 0)
>> +++ libavcodec/dnxhdenc.c	(revision 0)
>> @@ -0,0 +1,682 @@
>> +/*
>> + * VC3/DNxHD encoder.
>> + * Copyright (c) 2007 Baptiste Coudurier <baptiste dot coudurier at smartjog dot com>.
> 
> nit: The periods are senseless.
> 
>> +    weigth_matrix = (n&2) ? ctx->cid_table->chroma_weigth : ctx->cid_table->luma_weigth;
>> +
>> +    for(i = 1; i < last_index; i++) {
> 
> for (

right.

>> --- libavformat/movenc.c	(revision 10288)
>> +++ libavformat/movenc.c	(working copy)
>> @@ -516,6 +516,51 @@
>>  
>> +/* also used by all avid codecs flavors (dv, imx, meridien) */
> 
> codec

Ok, there are many codecs and many flavors of those codecs though.

> Also, isn't it meridiAn?

Avid says MeridiEn

>> --- libavcodec/Makefile	(revision 10288)
>> +++ libavcodec/Makefile	(working copy)
>> @@ -358,6 +359,7 @@
>>  OBJS-$(CONFIG_VP6_DECODER)             += i386/vp3dsp_mmx.o i386/vp3dsp_sse2.o
>>  OBJS-$(CONFIG_VP6F_DECODER)            += i386/vp3dsp_mmx.o i386/vp3dsp_sse2.o
>>  OBJS-$(CONFIG_SNOW_DECODER)            += i386/snowdsp_mmx.o
>> +OBJS-$(CONFIG_DNXHD_ENCODER)           += i386/dnxhd_mmx.o
>>  endif
> 
> This should be sorted.

Ok.

>> --- libavcodec/dnxhdenc.h	(revision 0)
>> +++ libavcodec/dnxhdenc.h	(revision 0)
>
> [...]
> 
>> +#endif  // AVCODEC_DNXHDENC_H
> 
> Don't /* */ look that much nicer? ;-)
> 

Well I find // simpler and easier to write ;-), but if you really want....

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312