[FFmpeg-devel] [PATCH] DNxHD/VC-3 encoder

[Diego Biurrun]

On Wed, Sep 05, 2007 at 12:45:59PM +0200, Baptiste Coudurier wrote:
> 
> Diego Biurrun wrote:
> > On Tue, Sep 04, 2007 at 07:39:46PM +0200, Baptiste Coudurier wrote:
> >> Here is the encoder.
> >>
> >> --- libavformat/movenc.c	(revision 10288)
> >> +++ libavformat/movenc.c	(working copy)
> >> @@ -516,6 +516,51 @@
> >>  
> >> +/* also used by all avid codecs flavors (dv, imx, meridien) */
> > 
> > codec
> 
> Ok, there are many codecs and many flavors of those codecs though.

Hmmm, then I think you should say it explicitly as it is not immediately
clear from what you write, i.e.

  also used by all avid codecs (dv, imx, meridien) and their variants

> > Also, isn't it meridiAn?
> 
> Avid says MeridiEn

OK

> >> --- libavcodec/dnxhdenc.h	(revision 0)
> >> +++ libavcodec/dnxhdenc.h	(revision 0)
> >
> > [...]
> > 
> >> +#endif  // AVCODEC_DNXHDENC_H
> > 
> > Don't /* */ look that much nicer? ;-)
> 
> Well I find // simpler and easier to write ;-), but if you really want....

I prefer C-style comments, but I don't really care.

Diego