[FFmpeg-devel] [PATCH] VBR header for "libmp3lame"

Peter Belkner pbelkner at snafu.de
Sat Apr 16 11:21:20 CEST 2011

On 16.04.2011 11:17, Carl Eugen Hoyos wrote:
>> +#define AVCTX_IS_VBR(avctx) ((avctx)->flags&  CODEC_FLAG_QSCALE)
> This is only used once in the new code, and it implies an additional changed
> line, making reading the patch slightly more difficult.

It's used two times. That's the reason for defing it.

> +        if (NULL == data
> This style would be very unusual for FFmpeg, please use "!data".

Thanks for the hint.


More information about the ffmpeg-devel mailing list