[FFmpeg-devel] [PATCH] VBR header for "libmp3lame"

Carl Eugen Hoyos cehoyos at ag.or.at
Sat Apr 16 11:24:54 CEST 2011


Peter Belkner <pbelkner <at> snafu.de> writes:

> >> +#define AVCTX_IS_VBR(avctx) ((avctx)->flags&  CODEC_FLAG_QSCALE)
> >>      
> > This is only used once in the new code, and it implies an additional changed
> > line, making reading the patch slightly more difficult.
> 
> It's used two times. That's the reason for defing it.

I found it only once in the code added by you, and since it implies the purely
cosmetic change of an additional line, it makes reading your patch slightly more
difficult.

Carl Eugen



More information about the ffmpeg-devel mailing list