[FFmpeg-devel] [PATCH] VBR header for "libmp3lame"

Carl Eugen Hoyos cehoyos at ag.or.at
Sat Apr 16 12:22:22 CEST 2011

Peter Belkner <pbelkner <at> snafu.de> writes:

> If it is of any importance

It is not.

What is important is that there are two kinds of "reviews":
I like your patch (if it works - I did not test - it obviously fixes an issue
likely to hit many users), so I could answer "ok" (or even push the patch).
But that would not be a review.

The true review takes time (apart from knowledge) and it makes sense to try hard
to make this review as easy as possible by making the patch as small as possible
(if you have to re-indent one line I agree you do not have to do this in a
separate patch).

Again: Thanks for your effort!

Carl Eugen

More information about the ffmpeg-devel mailing list