[FFmpeg-devel] [PATCH] VBR header for "libmp3lame"

Peter Belkner pbelkner at snafu.de
Sat Apr 16 12:06:22 CEST 2011

On 16.04.2011 11:24, Carl Eugen Hoyos wrote:
> Peter Belkner<pbelkner<at>  snafu.de>  writes:
>>>> +#define AVCTX_IS_VBR(avctx) ((avctx)->flags&   CODEC_FLAG_QSCALE)
>>> This is only used once in the new code, and it implies an additional changed
>>> line, making reading the patch slightly more difficult.
>> It's used two times. That's the reason for defing it.
> I found it only once in the code added by you, and since it implies the purely
> cosmetic change of an additional line, it makes reading your patch slightly more
> difficult.

The first appearence on it's own may look like a cosmetic change. The 
second apperance is below where the extradata is allocated. This is only 
done in case of VBR.

If it is of any importance I expand the macro on both places and remove 
it's definition.


More information about the ffmpeg-devel mailing list